Julien Lepiller <jul...@lepiller.eu> writes: > On Sat, 15 Oct 2016 16:51:00 -0400 > Kei Kebreau <k...@openmailbox.org> wrote: > >> Julien Lepiller <jul...@lepiller.eu> writes: >> >> > Hi, >> > >> > I attached a patch to add fbida, a frame-buffer based image and pdf >> > viewer. I created a new file, since I didn't find an existing one >> > where it could go. Let me know if you prefer it in an existing >> > file. >> >> Hi Julien! Your patch looks fine as far as linting and reproducibility >> goes. Some pointers for your patch: >> >> In my opinion, this can go in pdf.scm, as the mupdf package is there >> and it has similar functions to fbida. Also, when you add fbida to >> pdf.scm, don't forget to add a copyright notice for yourself! > > I attached an updated patch.
Thanks! This works just as well for me. Pushed as f3e222165e7c2393441346d4efd82d03a84a1fac. For future reference, when adding a package you only need gnu: Add [package]. * gnu/packages/[file].scm ([package]): New variable. as far as commit syntax goes. :-)
Description: PGP signature