Leo Famulari <[email protected]> writes: > On Mon, Oct 17, 2016 at 05:55:04PM +0100, Marius Bakke wrote: >> * gnu/packages/patches/notmuch-emacs-25-compatibility-fix.patch: New file. >> * gnu/local.mk (dist_patch_DATA): Register it. >> * gnu/packages/mail.scm (notmuch)[arguments]: Add verbose make flags. >> Add phase 'patch-notmuch-lib.el' to fix hard-coded /bin/sh. >> Add 'prepare-test-environment' phase to patch test shebangs and set >> environment. >> [native-inputs]: Change from 'emacs-minimal' to 'emacs-no-x'. Add dtach, >> gnupg, man, perl and which. > > A true nit-pick, but all those lines should start at column 0 rather > than being indented.
Noted. > >> + (patches >> + ;; This is included in the next release. >> + ;; https://notmuchmail.org/pipermail/notmuch/2016/023309.html >> + (search-patches >> "notmuch-emacs-25-compatibility-fix.patch")))) > > Please mention the use of this patch in the commit changelog. Oops, thanks! > >> + ;; The following are required for tests only. >> + ("which" ,which) >> + ("dtach" ,dtach) >> + ("gnupg" ,gnupg) >> + ("man" ,man-db) >> + ("perl" ,perl))) > > Can you check if these inputs are referenced by the output? Ideally > not... > > $ guix gc --references $(./pre-inst-env guix build notmuch) Good point, I did not verify this until now. They are not referenced by the output. > >> diff --git a/gnu/packages/patches/notmuch-emacs-25-compatibility-fix.patch >> b/gnu/packages/patches/notmuch-emacs-25-compatibility-fix.patch >> new file mode 100644 >> index 0000000..456b345 >> --- /dev/null >> +++ b/gnu/packages/patches/notmuch-emacs-25-compatibility-fix.patch >> @@ -0,0 +1,43 @@ >> +From f575a346df09c82691bb9e7c462836d982fe31f7 Mon Sep 17 00:00:00 2001 >> +From: David Bremner <[email protected]> >> +Date: Sun, 9 Oct 2016 19:30:44 -0300 >> +Subject: [PATCH] emacs/show: force notmuch-show-buttonise-links to act on >> + lines > > If possible, please add a hyperlink to the source of the patch. Ideally, > to a Git commit in a web-based Git repo interface. > > Not knowing Emacs Lisp, I can't comment on the patch itself. The bug was exposed by enabling tests against emacs 25 and will be included in the next release. See this thread: https://notmuchmail.org/pipermail/notmuch/2016/023227.html I will add a gitweb link to the patch header.
