Marius Bakke <[email protected]> writes: > ng0 <[email protected]> writes: > >> Hi, >> >> thanks for reviewing. >> >> Marius Bakke <[email protected]> writes: >> >>> ng0 <[email protected]> writes: >>> >>>> * gnu/packages/vim.scm (vim-full): New variable. >>>> * gnu/packages/patches/vim-8.0.0003.patch: New file. >>>> * gnu/packages/patches/vim-8.0.0004.patch: New file. >>>> * gnu/packages/patches/vim-8.0.0005.patch: New file. >>>> * gnu/local.mk (dist_patch_DATA): Add patches. >>>> --- >>>> gnu/local.mk | 3 ++ >>>> gnu/packages/patches/vim-8.0.0003.patch | 87 >>>> +++++++++++++++++++++++++++++++++ >>>> gnu/packages/patches/vim-8.0.0004.patch | 60 +++++++++++++++++++++++ >>>> gnu/packages/patches/vim-8.0.0005.patch | 45 +++++++++++++++++ >>>> gnu/packages/vim.scm | 81 >>>> ++++++++++++++++++++++++++++++ >>>> 5 files changed, 276 insertions(+) >>>> create mode 100644 gnu/packages/patches/vim-8.0.0003.patch >>>> create mode 100644 gnu/packages/patches/vim-8.0.0004.patch >>>> create mode 100644 gnu/packages/patches/vim-8.0.0005.patch >>> >>> [...] >>> >>>> + >>>> +(define-public vim-full >>>> + (package >>>> + (inherit vim) >>>> + (name "vim-full") >>>> + (version (package-version vim)) >>>> + (source >>>> + (origin >>>> + (method url-fetch) >>>> + (uri (string-append "ftp://ftp.vim.org/pub/vim/unix/vim-"; >>>> + version ".tar.bz2")) >>>> + (sha256 >>>> + (base32 >>>> + "1s34rf8089klsbdx5l0iw7vjymir0kzfrx8wb30s31wygnq29axc")) >>>> + ;; Patches need to be applied sequentially. 8.0 is the release of >>>> + ;; vim version 8.0.0002 so we start at 8.0.0003 >>>> + (patches (search-patches "vim-8.0.0003.patch" >>>> + "vim-8.0.0004.patch" >>>> + "vim-8.0.0005.patch")))) >>> >>> Shouldn't these patches be applied on the base vim package? Then >>> "vim-full" can just inherit the source from there. I also think >>> "version" should be adjusted to match the patch level. >> >> No (for explanation see the other emails I've sent in the earlier >> thread). >> I agree on the version, I will update that. > > Upstream recommends using the Github releases [0]
Where? Do you have any link for that quote so I can link it? for 8.0 which are at > 8.0.0042 already. Do you think it makes sense to switch to that source > for both packages? Then we might avoid carrying the patches entirely. > > 0: https://github.com/vim/vim/releases >
