Marius Bakke <[email protected]> skribis: > Ludovic Courtès <[email protected]> writes: > >> civodul pushed a commit to branch master >> in repository guix. >> >> commit ef753a1a8f9e7c971957abfda9b672a7728cd073 >> Author: Ludovic Courtès <[email protected]> >> Date: Tue Feb 7 11:14:09 2017 +0100 >> >> gnu: grub-efi: Really build the EFI variant. >> >> Fixes a regression introduced in >> d846834fc2b2f76aa2e258685bc211edd31866c5 where '--with-platform=efi' >> would no longer be passed. >> >> * gnu/packages/grub.scm (grub-efi)[arguments]: Provide a default value >> for #:configure-flags. > > [...] > >> @@ -139,8 +139,8 @@ menu to select one of the installed operating systems.") >> ;; Search for 'OVMF' in "tests/util/grub-shell.in". >> #:tests? #f >> ,@(substitute-keyword-arguments (package-arguments grub) >> - ((#:configure-flags flags) `(cons* "--with-platform=efi" >> - ,flags)) >> + ((#:configure-flags flags ''()) >> + `(cons "--with-platform=efi" ,flags)) >> ((#:phases phases) >> `(modify-phases ,phases >> (add-after 'patch-stuff 'use-absolute-efibootmgr-path > > Thank you for this! I did test grub-efi with the new grub release, but > then afterwards checked whether the #:configure-flags were still needed. > > I will be more careful about this in the future.
No problem, it’s easy to get tripped up with things that inherit and customize flags. Ludo’.
