On Mon 27 Feb 2017 10:39, Clément Lassieur <[email protected]> writes:
> Clément Lassieur <[email protected]> writes: > >> Andy Wingo <[email protected]> writes: >> >>> On Sun 26 Feb 2017 20:42, Clément Lassieur <[email protected]> writes: >>> >>>> * gnu/services/mail.scm (unix-listener-configuration)[path] >>>> (fifo-listener-configuration)[path]: Change type from 'file-name' to >>>> 'string'. >>>> * doc/guix.texi (Mail Services): Document it. >>> >>> Why's that? Is the extra checking from the file-name type (that the >>> string start with "/") getting in the way of something? >> >> Yes, because the path is also used as the section name (see >> http://wiki2.dovecot.org/Services#Service_listeners). >> >> So for example, this code (from gnu/services/mail.scm:445) raises an >> error because "lmtp" doesn't start with "/": >> >> (service-configuration >> (kind "lmtp") >> (listeners >> (list (unix-listener-configuration (path "lmtp") (mode "0666"))))) >> >> I don't understand how it could work before. Maybe the check wasn't >> done. > > Well, maybe here "lmtp" is not the section name, but the path, relative > to "base_dir". Sould I update the documentation to specify that "path" > may be relative to "base_dir" too? Sure, anyway patch LGTM. Thanks for taking the time to explain. Andy
