Thanks Gábor,
I'll make these changes and make a patch file and try to send across.

Lakshmi Prasannakumar
Bangalore


On Tue, Oct 30, 2018 at 2:28 AM Gábor Boskovits <boskov...@gmail.com> wrote:

> Hello Lakshmi,
>
> I did a preliminary review, that can make this contribution faster.
> Here are my comments:
>
> (package
>   (name "r-weights")
>   (version "1.0")
>   (source
>     (origin
>       (method url-fetch)
>       (uri (cran-uri "weights" version))
>       (sha256
>         (base32
>           "0186bfpkhxngrshac6bpg37alp6slwhwd43inrm8hqg0vhpfgc4c"))))
>   (build-system r-build-system)
>   (propagated-inputs
>     `(("r-gdata" ,r-gdata)
>       ("r-hmisc" ,r-hmisc)
>       ("r-mice" ,r-mice)))
>   (home-page
>     "http://cran.r-project.org/web/packages/weights";)
>   (synopsis "Weighting and Weighted Statistics")
>
> Please use lower case for all words except the first.
> The importer cannot find out which letters should be lower case,
> this has to be done manually.
>
>   (description
>     "Provides a variety of functions for producing simple weighted
> statistics, such as weighted Pearson's correlations, partial
> correlations, Chi-Squared statistics, histograms, and t-tests.  Also
> now includes some software for quickly recoding survey data and
> plotting point estimates from interaction terms in regressions (and
> multiply imputed regressions).  NOTE: Weighted partial correlation
> calculations pulled to address a bug.")
>
> Please, try to repharse this so that it has whole sentences, for
> example like "This package provides...".
>
>   (license gpl2+))
>
> With these small modifications this looks good to me.
>

Reply via email to