Hi, Robert Vollmert <r...@vllmrt.net> skribis:
>>> The current status of the evaluation of wip-haskell-updates is quite >>> confusing. There are a number of jobs listed as “Scheduled” with a red >>> X mark at the front. Is this a bug? >> >> I think I found what causes this: Those jobs were actually in state >> “started”, which fell through to failed. >> >> The patch below should complete the list, and make falling through >> noticeable: > > Apologies, I’d truncated the patch. A dedicated “started” icon would > be nice, too, but I didn’t find anything fitting in the font. Good catch! > diff --git a/src/cuirass/templates.scm b/src/cuirass/templates.scm > index ab1b85c..7fab879 100644 > --- a/src/cuirass/templates.scm > +++ b/src/cuirass/templates.scm > @@ -130,27 +130,40 @@ > (define status (assq-ref build #:status)) > (define display-status > (cond > - ((= (build-status succeeded) status) > - `(span (@ (class "oi oi-check text-success") > - (title "Succeeded")) > - " Success")) In general please try to minimize patches; in this case, I think this hunk can remain here. > (else > - `(span (@ (class "oi oi-x text-danger") > - (title "Failed")) > - " Failed")))) > + `(span (@ (class "oi oi-warning text-danger") > + (title "Invalid status")) > + " Invalid status")))) Much better! Please push to cuirass.git (with a commit log). Thank you! Ludo’.
