Hi Jelle, Jelle Licht <[email protected]> skribis:
> Cayetano Santos <[email protected]> writes: > >> Hi Guix, >> >> Out of curiosity, I had a closer look to trealla, a frequent inhabitant >> of Guix log: 344 commits during last 2 years, roughly speaking, a >> constant pace of a new commit every two days. > > I am actually wondering how these bumps are happening this fast on our > end; I thought everything-but-emergency-reverts should go through a pull > request for review; is this no longer (/ was this never) the case for > leaf packages? I can't seem to find pull requests for most of these > bumps, after a very limited time of looking for them on codeberg. . The policy suggests that changes are always submitted for review: https://guix.gnu.org/manual/devel/en/html_node/Commit-Access.html#Commit-Policy But in another section, there’s an explicit exception allowing committers to push “trivial” changes without review: https://guix.gnu.org/manual/devel/en/html_node/Managing-Patches-and-Branches.html I would personally be in favor of removing the exception for “trivial” changes and requiring pull requests for every change. Also, I would like us committers to always wait for @guix-cuirass-bot feedback, except in cases where the pull request targets a branch other than ‘master’ that pulls.ci won’t be able to build. Thoughts? Ludo’.
