Ludovic Courtès <[email protected]> writes: > Hi Jelle,
<snip> > The policy suggests that changes are always submitted for review: > > > https://guix.gnu.org/manual/devel/en/html_node/Commit-Access.html#Commit-Policy > > But in another section, there’s an explicit exception allowing > committers to push “trivial” changes without review: > > > https://guix.gnu.org/manual/devel/en/html_node/Managing-Patches-and-Branches.html Ah that explains it; I had (mis)read this as if they were the entire list of trivial changes, and not just some examples. My bad! > I would personally be in favor of removing the exception for “trivial” > changes and requiring pull requests for every change. I have no strong preferences here. > Also, I would like us committers to always wait for @guix-cuirass-bot > feedback, except in cases where the pull request targets a branch other > than ‘master’ that pulls.ci won’t be able to build. I worry that this will slow (almost) trivial PRs down a lot, but that is obviously me wearing my "let's get some code merged" hat on ;-). > > Thoughts? > > Ludo’. Thanks, as always! - Jelle
