Hi, Sorry for empty email, I send this by arror.
The main goal of the interface name is to stay compatible with old implementation of interface. But if there is no problem about breaking old implementation the we can just update the old interface methods without creating new interfaces; however we have to change the function name in order to alert developers. Regards, Nicolas Fortin, IRSTV FR CNRS 2488 Le jeudi 30 janvier 2014 08:36:51 UTC+1, Thomas Mueller a écrit : > > Hi, > > The patch is good, thanks a lot! The only change I have in mind (but I can > do that) is to change the names of the interfaces. Currently you have: > > AggregateAlias (new base interface) > AggregateFunction extends AggregateAlias (the current interface, > deprecated) > AggregateTypeFunction extends AggregateAlias (new interface) > > Maybe it's easier to not use a base interface (not use AggregateAlias), > but deprecate the old interface (AggregateFunction), and create a new > interface and simply call that one "Aggregate". An implementation could > support both interfaces, in which case H2 would use "Aggregate" (the new > version). > > What do you think? > > Regards, > Thomas > > > > > On Wed, Jan 29, 2014 at 8:54 AM, Nicolas Fortin (OrbisGIS) < > [email protected] <javascript:>> wrote: > >> Hi, >> >> Does this patch require more modifications to be accepted ? I will try to >> not miss the next h2 release in order to release a new H2GIS version on >> maven central. >> >> >> Thank you >> >> Regards, >> >> Nicolas Fortin >> Atelier SIG, IRSTV FR CNRS 2488 >> >> Le mardi 21 janvier 2014 11:13:25 UTC+1, Nicolas Fortin (OrbisGIS) a >> écrit : >> >>> Hi, >>> >>> As you requested I commit something about user defined aggregate >>> function. A new interface use H2 internal type codes instead of sql type >>> codes. >>> >>> https://github.com/nicolas-f/H2-Mirror/compare/h2-fork-r5429 >>> https://github.com/nicolas-f/H2-Mirror/compare/h2-fork-r5429.diff >>> https://github.com/nicolas-f/H2-Mirror/compare/h2-fork-r5429.patch >>> >>> Thank you >>> >>> Regards, >>> >>> Nicolas Fortin >>> Atelier SIGn; IRSTV FR CNRS 2488 >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "H2 Database" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> To post to this group, send email to [email protected]<javascript:> >> . >> Visit this group at http://groups.google.com/group/h2-database. >> For more options, visit https://groups.google.com/groups/opt_out. >> > > -- You received this message because you are subscribed to the Google Groups "H2 Database" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/h2-database. For more options, visit https://groups.google.com/groups/opt_out.
