Hi Thomas,

Here is a new patch that takes account of your advice:

https://github.com/nicolas-f/H2-Mirror/compare/h2-fork-r5473
https://github.com/nicolas-f/H2-Mirror/compare/h2-fork-r5473.patch
https://github.com/nicolas-f/H2-Mirror/compare/h2-fork-r5473.diff

Thanks for your help

-Nicolas
Atelier SIG, IRSTV FR CNRS 2488

Le jeudi 30 janvier 2014 08:36:51 UTC+1, Thomas Mueller a écrit :
>
> Hi,
>
> The patch is good, thanks a lot! The only change I have in mind (but I can 
> do that) is to change the names of the interfaces. Currently you have:
>
> AggregateAlias (new base interface)
> AggregateFunction extends AggregateAlias (the current interface, 
> deprecated)
> AggregateTypeFunction extends AggregateAlias (new interface)
>
> Maybe it's easier to not use a base interface (not use AggregateAlias), 
> but deprecate the old interface (AggregateFunction), and create a new 
> interface and simply call that one "Aggregate". An implementation could 
> support both interfaces, in which case H2 would use "Aggregate" (the new 
> version).
>
> What do you think?
>
> Regards,
> Thomas
>

-- 
You received this message because you are subscribed to the Google Groups "H2 
Database" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/h2-database.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to