Hi Neil,

I've reviewed the Makefiles, but not the other files.

usr/src/cmd/ha-services/gds-agents/ids/Makefile:
        Based on the other gds Makefiles you're missing one line:
        LINTFILES=

The rest looks good. I'm assuming the packaging changes will be part of 
a subsequent review.

Thanks
Jonathan


Neil Garthwaite wrote:

> Hi Everyone,
> 
> The HA-Informix project page 
> http://opensolaris.org/os/project/ha-informix has been updated to 
> include the initial code for the HA-Informix agent.
> 
> I'd welcome a code review for this agent, a webrev can be found here
> 
>  http://cr.opensolaris.org/~neilg/ohacds-informix
> 
> Alternatively, the agent is available for download. Please use the 
> accompanying cheatsheet if you want to try out the agent.
> 
>  http://opensolaris.org/os/project/ha-informix/cheatsheet_ohac_ids.pdf
> 
> Finally, many thanks to everyone that reviewed the Design Doc and Caller 
> Sequence Doc, I've updated those docs to reflect your comments.
> 
> Regards
> Neil
> 
> 
> _______________________________________________
> ha-clusters-discuss mailing list
> ha-clusters-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss

Reply via email to