Hi Neil,
Please find my comments below:
1. ids/ids_register:
Line #: 60
Stop_signal=9 What is the stop_signal you are referring to here? Did you
mean SIGSTOP?
2. ids/functions:
a) I would suggest the location of LOGFILE be set to something like
/var/cluster/logs/ha-ids/${RESOURCE}_logfile instead of /var/tmp/
27 LOGFILE=/var/tmp/${RESOURCE}_logfile
b) You may want to do this check
197 if [ -f "${INFORMIXDIR}/etc/${ONCONFIG}" ]
inside this condition
if [ -d "${INFORMIXDIR}" ]
166 then
167 debug_message "Validate - ${INFORMIXDIR} exists"
c) We could use a similar message in validate as well for the user
to know that validate was successful. I see only debug/error messages
in the validate function.
# SCMSGS
325 # @explanation
326 # The specified Informix Server was started successfully.
327 # @user_action
328 # None required. Informational message.
329 scds_syslog -p daemon.notice -t $(syslog_tag) -m \
330 "start_ids - Informix Server (%s) started rc(%s)" \
331 "${INFORMIXSERVER}" "${rc}"
3. If Informix DS is already running outside sun cluster control, how is it
handled?
You bail-out or do something else?
4. Is there any cleanipc kind of utility in Informix installation? If yes, you
could use
the same utility instead of cleanup_ipcs function. If not, this is fine too.
5. ids/ids_smf_register:
I have executed this script just to check if xml file is created. At the
outset, it failed with the
error:
syntax error at line 36 : `<<' unmatched
Then I found out that the second EOF should have a literal TAB or NO SPACE
before.
121 EOF
Since I copied it from webrev, there were spaces in the .ksh file. I am sure
you would have had a tab out there.
6. Except "Makefile" none of the files has a Sun Copyright. Is it not required?
7. ids/ids_config:
I am not sure how much this information
" To use the Sun Cluster Data Service for Informix Dynamic Server
58 # together with the Sun Cluster Data Service for Solaris Containers"
is required here. But this should definitely be captured in the doc guide.
Thanks,
Swathi
>Neil Garthwaite wrote:
>
>
>>Hi Everyone,
>>
>>The HA-Informix project page
>>http://opensolaris.org/os/project/ha-informix has been updated to
>>include the initial code for the HA-Informix agent.
>>
>>I'd welcome a code review for this agent, a webrev can be found here
>>
>> http://cr.opensolaris.org/~neilg/ohacds-informix
>>
>>Alternatively, the agent is available for download. Please use the
>>accompanying cheatsheet if you want to try out the agent.
>>
>> http://opensolaris.org/os/project/ha-informix/cheatsheet_ohac_ids.pdf
>>
>>Finally, many thanks to everyone that reviewed the Design Doc and Caller
>>Sequence Doc, I've updated those docs to reflect your comments.
>>
>>Regards
>>Neil
>>
>>
>_______________________________________________
>ha-clusters-discuss mailing list
>ha-clusters-discuss at opensolaris.org
>http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
>
>
>
