Hi Neil, thanks for your review, I have made the change and uploaded the webrev again.
Detlef Neil Garthwaite wrote: > Hi Detlef, > > I'm fine with the changes, just one minor comment. > > functions.ksh > - Lines 482-489, presumably once the test is matched you can break > out of the for/do loop. > > Regards > Neil > > > On 27 Feb 2009, at 07:39, Detlef Ulherr wrote: > >> Hi, >> >> I would like to propose the following bugfixes of the ha-mysql agent. >> >> 6804858 mysql_register.ksh should not use pkginfo to determine the >> cluster version >> 6805990 it should be possible to register more than one mysql >> database in a protection group >> 6806206 The MySQL geocontrol disables the replication resource on >> validation >> >> >> However, In addition to these bugs I replaced add-devicegroup >> keyword in the geopg command by add-replication-component which is >> more about what I am doing by keeping the same functionality. >> >> The webrev is located under: >> http://cr.opensolaris.org/~ulherr/mysql-pkginfo+sbp/ >> >> This times out at Tuesday March 3rd. >> >> Any comments are highly appreciated >> >> Kind Regards >> Detlef >> >> -- >> >> ***************************************************************************** >> >> >> Detlef Ulherr >> Staff Engineer Tel: (++49 6103) 752-248 >> Availability Engineering Fax: (++49 6103) 752-167 >> Sun Microsystems GmbH Amperestr. >> 6 mailto:detlef.ulherr at sun.com >> 63225 Langen http://www.sun.de/ >> ***************************************************************************** >> >> >> >> Sitz der Gesellschaft: Sun Microsystems GmbH, Sonnenallee 1, D-85551 >> Kirchheim-Heimstetten >> Amtsgericht Muenchen: HRB 161028 >> Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer >> Vorsitzender des Aufsichtsrates: Martin Haering >> >> ***************************************************************************** >> >> >> >> >> _______________________________________________ >> ha-clusters-discuss mailing list >> ha-clusters-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss > -- ***************************************************************************** Detlef Ulherr Staff Engineer Tel: (++49 6103) 752-248 Availability Engineering Fax: (++49 6103) 752-167 Sun Microsystems GmbH Amperestr. 6 mailto:detlef.ulherr at sun.com 63225 Langen http://www.sun.de/ ***************************************************************************** Sitz der Gesellschaft: Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht Muenchen: HRB 161028 Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer Vorsitzender des Aufsichtsrates: Martin Haering *****************************************************************************
