Hi Thorsten,
Thanks for the review, I incorporated the comment and uploaded the webrev. Detlef Thorsten Frueauf wrote: > Hi Detlef et al, > > > very minor nit: > > - > usr/src/cmd/ha-services/gds-agents/mys/geocontrol/mysql_geo_register.ksh > * line 215, double space, change > "if create_rc" > to > "if create_rc" > > > Changes look fine to me otherwise. > > Greets > Thorsten > > Detlef Ulherr wrote: >> Hi, >> >> I would like to propose the following bugfixes of the ha-mysql agent. >> >> 6804858 mysql_register.ksh should not use pkginfo to determine the >> cluster version >> 6805990 it should be possible to register more than one mysql >> database in a protection group >> 6806206 The MySQL geocontrol disables the replication resource on >> validation >> >> >> However, In addition to these bugs I replaced add-devicegroup >> keyword in the geopg command by add-replication-component which is >> more about what I am doing by keeping the same functionality. >> >> The webrev is located under: >> http://cr.opensolaris.org/~ulherr/mysql-pkginfo+sbp/ >> >> This times out at Tuesday March 3rd. >> >> Any comments are highly appreciated >> >> Kind Regards >> Detlef > -- ***************************************************************************** Detlef Ulherr Staff Engineer Tel: (++49 6103) 752-248 Availability Engineering Fax: (++49 6103) 752-167 Sun Microsystems GmbH Amperestr. 6 mailto:detlef.ulherr at sun.com 63225 Langen http://www.sun.de/ ***************************************************************************** Sitz der Gesellschaft: Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht Muenchen: HRB 161028 Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer Vorsitzender des Aufsichtsrates: Martin Haering *****************************************************************************