Detlef,
Couple of minor comments:
531: Shouldn't the replication RG just have a strong affinity on the
MySQL app RG when it's added. So here, you don't need to specify which
node it is brought online on. The addition later of MySQL RG should sort
that out.
functions.ksh
629 if ${CLRS} list -g ${REPL_MYSQL_RESOURCEGROUP} | ${GREP}
"^${REPL_MYSQL_RESOURCE}$" >/dev/null 2>&1
seems a bit strange to me as
${CLRS} list -g ${REPL_MYSQL_RESOURCEGROUP} 2>&1
should produce the same result, i.e an exit code of 0 if it works and
non-zero if it fails. It also result in a string on success and nothing
on failure.
Ditto 653.
Tim
---
On 01/14/09 13:18, Detlef Ulherr wrote:
> Hi,
>
> I have provided a fix for the following bugs in MySQL agent for review.
>
> The webrev can be found at
> http://cr.opensolaris.org/~ulherr/mysql-sbp-patch/
>
> The following bugs are fixed:
> 6771179 the mysql_config file lacks necessary information if the
> geocontrol component should be configured
> 6772756 The replication resource must always go online on the where the
> database resource is
> 6772758 The ha_mysql_register script should not use the old cli
> 6776775 The remove_configuration function reports an error if nothing to do
> 6793558 stopping of the replication resource results in an error
>
> This review expires at January 15th.
>
> As always your comments are highly appreciated.
>
> Cheers
> Detlef
>
>
>
--
Tim Read
Staff Engineer
Solaris Availability Engineering
Sun Microsystems Ltd
Springfield
Linlithgow
EH49 7LR
Phone: +44 (0)1506 672 684
Mobile: +44 (0)7802 212 137
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
NOTICE: This email message is for the sole use of the intended
recipient(s) and may contain confidential and privileged information.
Any unauthorized review, use, disclosure or distribution is prohibited.
If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
