Hi Tim,
Thanks for the review,
Tim Read - Staff Engineer Solaris Availability Engineering wrote:
> Detlef,
>
> Couple of minor comments:
> 531: Shouldn't the replication RG just have a strong affinity on the
> MySQL app RG when it's added. So here, you don't need to specify which
> node it is brought online on. The addition later of MySQL RG should sort
> that out.
>
It has a strong positive with failover delegation affinity to the app
rg, but my testing at least when they should failover between zones,
showed that the failover worked, but on an clrg online always the first
zone in the list was picked regardless whether or not the apprg is
online there. See line 406 and 539 - 570.
> functions.ksh
> 629 if ${CLRS} list -g ${REPL_MYSQL_RESOURCEGROUP} | ${GREP}
> "^${REPL_MYSQL_RESOURCE}$" >/dev/null 2>&1
>
> seems a bit strange to me as
>
> ${CLRS} list -g ${REPL_MYSQL_RESOURCEGROUP} 2>&1
>
Good suggestion I will change that.
> should produce the same result, i.e an exit code of 0 if it works and
> non-zero if it fails. It also result in a string on success and nothing
> on failure.
>
> Ditto 653.
>
> Tim
> ---
>
>
> On 01/14/09 13:18, Detlef Ulherr wrote:
>
>> Hi,
>>
>> I have provided a fix for the following bugs in MySQL agent for review.
>>
>> The webrev can be found at
>> http://cr.opensolaris.org/~ulherr/mysql-sbp-patch/
>>
>> The following bugs are fixed:
>> 6771179 the mysql_config file lacks necessary information if the
>> geocontrol component should be configured
>> 6772756 The replication resource must always go online on the where the
>> database resource is
>> 6772758 The ha_mysql_register script should not use the old cli
>> 6776775 The remove_configuration function reports an error if nothing to do
>> 6793558 stopping of the replication resource results in an error
>>
>> This review expires at January 15th.
>>
>> As always your comments are highly appreciated.
>>
>> Cheers
>> Detlef
>>
>>
>>
>>
>
>
--
*****************************************************************************
Detlef Ulherr
Staff Engineer Tel: (++49 6103) 752-248
Availability Engineering Fax: (++49 6103) 752-167
Sun Microsystems GmbH
Amperestr. 6 mailto:detlef.ulherr at sun.com
63225 Langen http://www.sun.de/
*****************************************************************************
Sitz der Gesellschaft: Sun Microsystems GmbH, Sonnenallee 1, D-85551
Kirchheim-Heimstetten
Amtsgericht Muenchen: HRB 161028
Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Haering
*****************************************************************************
