Jonathan, It looks good. Just a couple questions:
It looks like we're not building the dtk package for the OSDIST build. Is that correct? What's the rationale for not building it? Regarding the jdk/jdmk changes: what is the OSDIST build dependent on in terms of jdk/jdmk? Thanks, Nick Thorsten Frueauf wrote: > Hi Jonathan et al, > > thanks for the update, GO from me :) > > Greets > Thorsten > > Jonathan Mellors wrote: >> Hi Thorsten, >> >> Thanks for the review and catching my typos in the build scripts. After >> updating them, I compared them with the hacked ones on the coips system, >> to check that they're now correct. I have run full builds and >> Hemachandran installed the opensolaris version on the ace cluster. >> >> The webrev has been refreshed. >> >> Thanks >> Jonathan >> >> >> Thorsten Frueauf wrote: >> >>> Hi Jonathan et al, >>> >>> here are my review comments: >>> >>> * usr/src/pkgdefs/Makefile >>> - line 79, remove the \ at the end of SUNWscspmu since it is the last >>> entry >>> >>> * usr/src/tools/scripts/nbmake.ksh >>> - line 1 needs to call sh not ksh: >>> #!/usr/xpg4/bin/sh >>> >>> * Raw usr/src/tools/scripts/nbuild.ksh >>> - line 1 needs to call sh not ksh: >>> #!/usr/xpg4/bin/sh >>> >>> I assume you did do a full build since I have no idea if the changes to >>> usr/src/lib/cmass/Makefile.cmass works :) >>> >>> Otherwise the changes look fine to me. >>> >>> Greets >>> Thorsten >>> >>> Jonathan Mellors wrote: >>> >>>> Hi Colorado folks, >>>> >>>> Here's the webrev for building Colorado on the opensolaris >>>> distribution. The majority of changes just distinguish the differences >>>> between building on an opensolaris distribution versus building on >>>> SXCE. The changes under usr/src/pkgdefs are temporary and will be >>>> removed once we're able to build IPS packages. >>>> >>>> Note: we're having some problems with Studio 12/StudioExpress, so I >>>> reverted to using Studio 11. >>>> >>>> Webrev is at: >>>> http://cr.opensolaris.org/~jmellors/osdist/ >>>> >>>> Thanks >>>> Jonathan >
