Hi Thorsten, Thorsten Frueauf wrote: > Hi Jonathan et al, > > turns out I did a closed build while I intended an open one, so forget > about my last comment below. > > The only point remaining is that jmxremote.jar is not available with > OpenSolaris, so within usr/src/lib/cmass/Makefile.cmass > > line 48 > $(OSDIST)EXTERNAL_JMX_CLASSPATH=$(JMX51_ROOT)/jmxremote.jar > needs to change to > $(OSDIST)EXTERNAL_JMX_CLASSPATH=$(JMX51_ROOT)/jmxremote_optional.jar
Since the build currently succeeds, we don't even need line 48. Thanks Jonathan > > Greets > Thorsten > > Thorsten Frueauf wrote: > >> Hi Jonathan et al, >> >> sorry for the "post mortem" comment, but it turns out that the change to >> >> usr/src/lib/cmass/Makefile.cmass >> >> is missing the lib directory. >> >> This means the change to line 48 >> $(OSDIST)EXTERNAL_JMX_CLASSPATH=$(JMX51_ROOT)/jmxremote.jar >> needs to change to >> $(OSDIST)EXTERNAL_JMX_CLASSPATH=$(JMX51_ROOT)/lib/jmxremote.jar >> >> and the change to line 53 >> $(OSDIST)EXTERNAL_JDMK_CLASSPATH=$(JDMK51_ROOT)/jdmkrt.jar >> needs to change to >> $(OSDIST)EXTERNAL_JDMK_CLASSPATH=$(JDMK51_ROOT)/lib/jdmkrt.jar >> >> Thanks to Hemachandran for pointing me to the right direction :) >> >> Greets >> Thorsten >> >> Thorsten Frueauf wrote: >> >>> Hi Jonathan et al, >>> >>> thanks for the update, GO from me :) >>> >>> Greets >>> Thorsten >>> >>> Jonathan Mellors wrote: >>> >>>> Hi Thorsten, >>>> >>>> Thanks for the review and catching my typos in the build scripts. >>>> After updating them, I compared them with the hacked ones on the >>>> coips system, to check that they're now correct. I have run full >>>> builds and Hemachandran installed the opensolaris version on the ace >>>> cluster. >>>> >>>> The webrev has been refreshed. >>>> >>>> Thanks >>>> Jonathan >>>> >>>> >>>> Thorsten Frueauf wrote: >>>> >>>>> Hi Jonathan et al, >>>>> >>>>> here are my review comments: >>>>> >>>>> * usr/src/pkgdefs/Makefile >>>>> - line 79, remove the \ at the end of SUNWscspmu since it is the >>>>> last entry >>>>> >>>>> * usr/src/tools/scripts/nbmake.ksh >>>>> - line 1 needs to call sh not ksh: >>>>> #!/usr/xpg4/bin/sh >>>>> >>>>> * Raw usr/src/tools/scripts/nbuild.ksh >>>>> - line 1 needs to call sh not ksh: >>>>> #!/usr/xpg4/bin/sh >>>>> >>>>> I assume you did do a full build since I have no idea if the >>>>> changes to usr/src/lib/cmass/Makefile.cmass works :) >>>>> >>>>> Otherwise the changes look fine to me. >>>>> >>>>> Greets >>>>> Thorsten >>>>> >>>>> Jonathan Mellors wrote: >>>>> >>>>>> Hi Colorado folks, >>>>>> >>>>>> Here's the webrev for building Colorado on the opensolaris >>>>>> distribution. The majority of changes just distinguish the >>>>>> differences between building on an opensolaris distribution versus >>>>>> building on SXCE. The changes under usr/src/pkgdefs are temporary >>>>>> and will be removed once we're able to build IPS packages. >>>>>> >>>>>> Note: we're having some problems with Studio 12/StudioExpress, so >>>>>> I reverted to using Studio 11. >>>>>> >>>>>> Webrev is at: >>>>>> http://cr.opensolaris.org/~jmellors/osdist/ >>>>>> >>>>>> Thanks >>>>>> Jonathan > >
