Hi Nick, Thanks for your review. See answers below.
Nicholas Solter wrote: > Lucia, > > I'm not a system management or build expert, but this looks fine to > me. Just a couple comments. > > usr/src/Makefile > > With these changes, do we now require Lockhart for doing an open build > even for Nevada? (I can't remember if we did before, but in this > Makefile, it looks like we didn't use Lockhart for a non-closed build > before your change). I think your observation is right, and I'll confirm with Jonathan. If we don't require LockHart for Nevada, I'll need to add another statement to set LOCKHART to nothing for Nevada. > > As we discussed, you'll be changing the NWAM logic to just issue an > error message and bailing out rather than trying to disable it. You > will also add the code to check on all nodes in all scenarios > (centralized install, add node, etc.) Right. I'll add these and send another review. Thanks, - Lucia > > Thanks, > Nick > > Lucia Lai wrote: >> Hi, >> >> To support the text based dsconfig wizard in opensolaris, we are >> switching to use jdk6 and openDMK that has IPS packages. The changes >> can be reviewed at >> >> http://cr.opensolaris.org/~llai/jdk_switch/ >> >> The changes include: >> >> - Updates to scinstall to remove checking for required shared >> components when do upgrade >> - Updates to scinstall to disable NWAM. >> - Fixes to java files are for javadoc build warnings. >> - Changes related to jdk6/openDMK switch. The old sasl.jar, jmx.jar, >> jmxremote.jar are all in rt.jar now. >> >> Here is the list of jars that we have dependencies at build time and >> run time: >> >> jar-file Build-time Run-time IPS pkg non-IPS URL >> ============================================================================== >> >> >> rt.jar Y Y SUNWj6rt >> jmxremote_optional.jar Y Y SUNWjdmk-base >> jdmkrt.jar Y Y SUNWjdmk-base >> jdmktk.jar Y N >> http://opendmk.dev.java.net/download/index.html >> mib_core.txt Y N >> http://opendmk.dev.java.net/download/index.html >> cacao_cacao.jar Y Y SUNWcacaort >> cacao_rbac.jar Y Y SUNWcacaort >> jato.jar Y N see note >> solaris_impl.jar Y N see note >> serviceapi.jar Y N see note >> jsp-api.jar Y N see note >> servlet-api.jar Y N see note >> cc.jar Y N see note >> >> note: These jars are in lockhart (3.0.2) can be downloaded from: >> >> https://cds.sun.com/is-bin/INTERSHOP.enfinity/WFS/CDS-CDS_SMI-Site/en_US/-/USD/ViewProductDetail-Start?ProductRef=WC-302-G-F >> at CDS-CDS_SMI >> >> >> >> Thanks, >> >> - Lucia >> >> _______________________________________________ >> ha-clusters-discuss mailing list >> ha-clusters-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss >
