Hi Lucia et al,
note that I am not a Java expert, thus I focused on non-Java related
things - though most of the java changes are within the comments
(javadoc) section.
Meta question, I see you provide a link to download Sun Java Web Console
3.0.2. Is your proposal that for an open build, this needs to be
installed on the OpenSolaris system? And from the table I assume this is
just required for building, not for runtime?
I did not download the .tar.gz file - does it contain SVR4 packages or
does it just unpack into a location? If there is an installation
mechanism, does that work on OpenSolaris?
These are my comments for the code changes:
- usr/src/Makefile.master
* line 248, you set LOCKHART unconditioned, I think you need to
prefix the $(CLOSED_BUILD) here.
For an open build the build instructions either need to call out
a location (which needs to be referenced here), or the necessary
files get installed - again the location needs to go here,
if this is required.
Otherwise LOCKHART needs to be empty for an open build.
* line 268, again you can only refer to /ws/... within a closed
build.
For an open build it needs to be a defined place where those
files need to get installed - and the build instructions
would need
to call that out.
- usr/src/cmd/cfgchk/lib/cfgchk_lib.ksh
- usr/src/cmd/clcommands/commands/clsetup/clsetup.ksh
- usr/src/cmd/sccheck/lib/sccheck_common.ksh
* all files have a functions (lib_test_java_version() or
common_test_java_version()) which would use the SVR4 package
commands.
Your change adds logic to ommit this if "/usr/bin/pkg" exists.
While this is fine, you might consider using the pkg command
within an else statement to retreive the same information out of
an IPS package - if there is any value doing that of course.
- usr/src/cmd/ha-services/hamasa/cmas_service_ctrl_check.sh
* while you eliminate line 40, I note that line 39 also uses
/usr/bin/pkgparam unconditioned to setup the CACAO_ROOT path.
I guess this needs to change for the IPS world as well?
- usr/src/cmd/ha-services/hamasa/cmas_service_ctrl_start.sh
- usr/src/cmd/ha-services/hamasa/cmas_service_ctrl_stop.sh
* same comment as for
usr/src/cmd/ha-services/hamasa/cmas_service_ctrl_check.sh
- usr/src/cmd/scinstall/lib/scinstall_common.ksh
* the generic comment is that the logic should be to error out
if NWAM is not disabled, instead of disabling it within the code.
For one it would terminate a session that uses the network
configured
by NWAM (maybe the admin himself), and it is not guaranteed that
svc:/network/physical:default has a valid network configuration.
* your logic only disabled NWAM if "/usr/bin/pkg" is present. But in
reality NWAM should always be disabled, even on Solaris
Express when
using the SVR4 packages.
Your check could just search for the nwam SMF service, and if
it exists, then it should check if it is disabled.
-
usr/src/lib/cmass/agent_dataservices/com/sun/cluster/agent/dataservices/hastorageplus/HAStoragePlus.java
* line 23, year is wrong - 200 instead of 2008
-
usr/src/lib/cmass/agent_dataservices/com/sun/cluster/agent/dataservices/sapwebas/SapWebas.java
-
usr/src/lib/cmass/agent_dataservices/com/sun/cluster/agent/dataservices/utils/Infrastructure.java
* line 23, copyright should just be 2008 (at least it was
changed that
way in other files)
- usr/src/lib/dsconfig/classes/Makefile
* line 71, the LOCKHART_PATH includes jato.jar - I thought that
was not
available on a OpenSolaris system. Does this needs a
$(CLOSE_BUILD)
as prefix?
What about an open build?
- usr/src/lib/model/classes/Makefile
* line 58, same comment as for usr/src/lib/dsconfig/classes/Makefile
The rest looks fine to me.
Greets
Thorsten
Lucia Lai wrote:
> Hi,
>
> To support the text based dsconfig wizard in opensolaris, we are
> switching to use jdk6 and openDMK that has IPS packages. The changes can
> be reviewed at
>
> http://cr.opensolaris.org/~llai/jdk_switch/
>
> The changes include:
>
> - Updates to scinstall to remove checking for required shared components
> when do upgrade
> - Updates to scinstall to disable NWAM.
> - Fixes to java files are for javadoc build warnings.
> - Changes related to jdk6/openDMK switch. The old sasl.jar, jmx.jar,
> jmxremote.jar are all in rt.jar now.
>
> Here is the list of jars that we have dependencies at build time and run
> time:
>
> jar-file Build-time Run-time IPS pkg non-IPS URL
> ==============================================================================
> rt.jar Y Y SUNWj6rt
> jmxremote_optional.jar Y Y SUNWjdmk-base
> jdmkrt.jar Y Y SUNWjdmk-base
> jdmktk.jar Y N
> http://opendmk.dev.java.net/download/index.html
> mib_core.txt Y N
> http://opendmk.dev.java.net/download/index.html
> cacao_cacao.jar Y Y SUNWcacaort
> cacao_rbac.jar Y Y SUNWcacaort
> jato.jar Y N see note
> solaris_impl.jar Y N see note
> serviceapi.jar Y N see note
> jsp-api.jar Y N see note
> servlet-api.jar Y N see note
> cc.jar Y N see note
>
> note: These jars are in lockhart (3.0.2) can be downloaded from:
>
> https://cds.sun.com/is-bin/INTERSHOP.enfinity/WFS/CDS-CDS_SMI-Site/en_US/-/USD/ViewProductDetail-Start?ProductRef=WC-302-G-F
> at CDS-CDS_SMI
>
>
> Thanks,
>
> - Lucia
--
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Sitz der Gesellschaft:
Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Amtsgericht Muenchen: HRB 161028
Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Haering
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
