Hi Neil,
Here's my review of the pkgdefs area.
usr/src/pkgdefs/jas.dvdimage.ksh:
I'd prefer your changes inserted into the lists alphabetically, instead
of at the end of sections. It's much easier to verify this file against
the built images and product lists if the order is maintained.
usr/src/pkgdefs/SUNWscids/pkginfo.tmpl:
As it's a new package, REV should be 0.0.0 on line 35
VERSION="3.2.0,REV=0.0.0"
The rest looks good.
Thanks
Jonathan
Neil Garthwaite wrote:
> Hi Everyone,
>
> Thought I'd start another thread. Anyway, many thanks for all the code
> reviews where I've implemented most of your comments.
>
> http://opensolaris.org/os/project/ha-informix/ has been updated to
> include a refreshed tarball and webrev. I'd appreciate any further
> reviews or comments.
>
> Also, please note that I have successfully performed some basic unit
> testing that includes the following:
>
> - Tested on SPARC and x86-64 clusters
> - Tested with non-global zones and failover zones
> - Tested with multiple instances
>
> Regards
> Neil
> _______________________________________________
> ha-clusters-discuss mailing list
> ha-clusters-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
