Hi Thorsten, Many thanks for the review, I've made the changes and updated the webrev. Please shift+reload if required.
Regards Neil On 19 Nov 2007, at 21:23, Thorsten Frueauf wrote: > Hi Neil, > > just some minor comments: > > * usr/src/cmd/ha-services/gds-agents/Makefile > > - line 40, is the added newline intended? > > > * usr/src/cmd/ha-services/gds-agents/ids/ids_smf_remove.ksh > > - line 60, recommend you call svcadm with full path (/usr/sbin) > > - line 66, recommend you call svccfg with full path (/usr/sbin) > > > The rest looks good to me :) > > Greets > Thorsten > > Neil Garthwaite wrote: >> Hi Everyone, >> >> Thought I'd start another thread. Anyway, many thanks for all the >> code >> reviews where I've implemented most of your comments. >> >> http://opensolaris.org/os/project/ha-informix/ has been updated to >> include a refreshed tarball and webrev. I'd appreciate any further >> reviews or comments. >> >> Also, please note that I have successfully performed some basic unit >> testing that includes the following: >> >> - Tested on SPARC and x86-64 clusters >> - Tested with non-global zones and failover zones >> - Tested with multiple instances >> >> Regards >> Neil > _______________________________________________ > ha-clusters-discuss mailing list > ha-clusters-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
