On Wed, Nov 26, 2008 at 8:39 AM, Owen Winkler <[EMAIL PROTECTED]> wrote:
> > rick c wrote: > > This has been ( correctly, I hope ) implemented in changeset 2886. > > > > Rick > > > > On Nov 24, 12:23 pm, Arthus Erea <[EMAIL PROTECTED]> wrote: > >> +1 > >> > >> The merits of E_STRICT shouldn't be ignored for development. That > >> being said, it isn't suitable for a production environment. > >> > >> Additionally, it should be a user-facing option (stored in the DB) to > >> set the error level. Ideally we would have different levels possible > >> (development, production, etc.) > > In my opinion, PHP error level settings should not be in the database. > Problems may exist in code prior to being able to access that data. > > Moreover, there are PHP settings (in the php.ini) in the server > environment that should be obeyed. The config file offers a place to > potentially override these settings for users without access to edit > their php.ini. > > My inclination would be to do nothing to the PHP error level setting by > default, leaving it to the php.ini to decide. I don't necessarily agree. Not only are the php.ini defaults often not satisfactory (think magic_quotes_gpc or register_globals), but they vary from install to install too much (each distro is a little bit different). > > > We need to consider the future of Habari, which should include > deployment from development to staging to production, where the > environment will set the reporting levels, and it will be inconvenient > to include in the deployed code or database. As with several other things, I think we should aim to hold our code to a higher standard. That means enforcing things like E_STRICT, rather than just going with whatever php.ini says. In any deployment scenario you're going to have to manage a config.php file for database settings. Why does including error reporting settings in there make deployment any more difficult? --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/habari-dev -~----------~----~----~----~------~----~------~--~---
