Chris Meller wrote: > > My inclination would be to do nothing to the PHP error level setting by > default, leaving it to the php.ini to decide. > > I don't necessarily agree. Not only are the php.ini defaults often not > satisfactory (think magic_quotes_gpc or register_globals), but they vary > from install to install too much (each distro is a little bit different).
But we're not talking about magic_quotes_gpc or register_globals, functions that would change the way the software operates. We're simply talking about the level of error that we want the system to allow to pass or report. > As with several other things, I think we should aim to hold our code to > a higher standard. That means enforcing things like E_STRICT, rather > than just going with whatever php.ini says. We do enforce E_STRICT during development. But as others have pointed out, 3rd-party modules are not completely beholden to our ideals. Users of Habari should be allowed to choose their reporting level, and should be able to do it in a familiar location, their php.ini, unless they specifically want to override it in their config file for that single Habari site. This would allow them to get by with, perhaps, less than ideal plugins, but we're not building perfection, we're building something usable, so I think that's ok. > In any deployment scenario you're going to have to manage a config.php > file for database settings. Why does including error reporting settings > in there make deployment any more difficult? It doesn't. Maybe this got lost along the way, but I'm advocating removing the E_STRICT (and any error reporting level change) from index.php, and documenting how to apply it to config.php so that users can set it how they like, if they choose. Owen --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/habari-dev -~----------~----~----~----~------~----~------~--~---
