On Feb 19, 2009, at 13:21, Owen Winkler wrote:
> Also in the realm of branches, I wanted to stop by the topic of bug > hunts. > > I think that we should not be using a single public-write branch for > bug > hunts. My concern with this is that changes are often poorly vetted > before merging with trunk. For the same reason that changes in code > convention formatting of a whole file obscure a subtle logic change > within that file, it is even more difficult to review changes when > multiple logical or functional changes overlap. > > I don't know the solution. I think I would rather patch and commit. > Opponents of that idea typically argue that patches are never reviewed > or committed, although I think that a bug hunt should imply the > assurance that there will be committers specifically available for > this > purpose. Of course, the same ideas apply to this as to branches -- > not > every patch is going to get in, and you'd do better by not coding in a > vacuum. I agree that bug fixes shouldn't require a branch. Bug fixes are typically a smallish piece of code, in a smallish number of files. They should simply be commited to trunk. And to any other branches in which they appear. But that should happen automatically when folks sync their branches with trunk. Which they should be doing every time they work on their branch. We are still a really small project. One side-effect of this is that patches don't get the massive reviews that a patch would on, say, Linux, where there are thousands of people watching the svn commit mlist at any given moment. But we're growing, and folks who care about code review, and are vocal about it, should be watching the commit mlist. Oh, and if you're going to change the style of a file - ie, any whitespace change, indentation change, etc - that commit should be free of functional changes. And vice versa. The problem that Owen is point out here is the bane of my existence. It happens a lot on multi- OS development teams, where Windows-users commit a file in which every line of the file is changed (End Of Line changes) but there's only one line of functional code change. Drives me absolutely bonkers. -- I have nature and art and poetry, and if that is not enough, what is enough? (Vincent van Gogh) --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/habari-dev -~----------~----~----~----~------~----~------~--~---
