> With so many people able to do so in Habari, it seems like there > should be multiple people reviewing code. I'd hate to find out that I > was the only person expected to do so. > > Is anyone now in the PMC able to step up and assume code review as his > own task? I think you don't even need to do the actual review, just > get it into the hands of the person who can.
I think you hit the nail on the head when you said it's a community project and that we're busy people with jacket-free summer days to enjoy. Some review does happen, and I don't expect that to be on the shoulders of any single person. One of my patches from this week was partially rolled back. I don't mind -- it worked for me, but not for everyone. In fact, I even rolled back one of Geoffrey's patches this week because it was causing the upload functionality in the silos to break (content-type header related). There are two ways to get anything done in open source (all open source, in my experience.. not just Habari): 1) gain the trust and respect of people with commit power and get them to do your bidding (or have them make you one of those people) 2) fork the project I'd suggest people who want their patches committed work on #1, but of course, they're free to do #2 with our license. S --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/habari-dev -~----------~----~----~----~------~----~------~--~---
