On Apr 6, 2009, at 09:48, Chris Meller wrote: > I don't care to comment on everything, I just want to express one > major concern here: > > "If you can convince a PMC member to commit your patch, they should > commit it." > > Not all PMC members are coders. Simply because you "present" your > patch well and can convince someone who doesn't know PHP or our code > that it's good doesn't make it so. Obviously not everything should > have to funnel through Owen, but at the same time having someone who > doesn't know what they're committing add code is also not an option > in my opinion. > > If we're going to take that approach, we may as well give anyone > access to commit code. The value in having a select group of members > who can actually add code is that review and education process by > someone who is more likely to be knowledgeable about not only our > code base in specific but best practices in general. > > We need to find a better way to do this, yes. That is not, in my > opinion, it.
Please take that statement in the following context: PMC members, you are the custodians of the Habari code. If you agree to commit code that you don't understand, SHAME ON YOU. Frankly, it didn't occur to me that the remark would be taken outside of that context. If we're bringing people onto the PMC who we think are so bereft of pride in their work, then I haven't noticed it. Have you? -- http://feathercast.org/ --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/habari-dev -~----------~----~----~----~------~----~------~--~---
