Ok, so that is an absolute requirement then, and the only issue? Was doing the patching in a very unconfigured chroot environment on a temporary computer, so hadn't setup email on there. I will for next time.
I know there are plenty of patches for dwm available, and I've made plenty of my own that are not meant for mainstream (I'll clean them up and submit someday.) I was wondering though, are there any things that are wanted for mainstream dwm? Happy to help. The TODO file seemed rather old, and I wasn't quite clear on what was meant by the updategeom hook. I also don't know what an appropriate change for scrot would be, as something with that functionality is available as a patch already (I'm guessing though something about it doesn't conform to mainstream dwm?) Chris On Wed, Mar 14, 2018 at 1:19 PM, Silvan Jegen <[email protected]> wrote: > Hi > > On Wed, Mar 14, 2018 at 5:58 PM, Christopher Drelich <[email protected]> > wrote: > > Any idea what I might have done wrong in creating the patch? I figure > > learning now will save us all time in the future. > > > > I followed the instructions on the website and used a fresh pull of dwm. > > Looking at what's in git, it seems the same to me, other than my email as > > you noted. > > You should use git send-email to send your patches by email (this > command consumes the output of git format-patch). I just saw that > https://suckless.org/hacking does not mention this... > > > Cheers, > > Silvan > > > > Chris > > > > On Wed, Mar 14, 2018 at 12:48 PM, Hiltjo Posthuma < > [email protected]> > > wrote: > >> > >> On Wed, Mar 14, 2018 at 10:12:55AM -0400, Christopher Drelich wrote: > >> > My first patch, I'm hoping this is the way you want them > submitted. I > >> > couldn't find any reason for ColBorder to be a #define while ColFg > >> > and > >> > ColBg are in an enum together. > >> > --- > >> > From eefea3c310db3c9460c5fdee3e8a8d0cb45c9819 Mon Sep 17 00:00:00 > >> > 2001 > >> > From: ude <ude@ude> > >> > Date: Wed, 14 Mar 2018 10:01:00 -0400 > >> > Subject: [PATCH] ColBorder has been moved to the enum with ColFg > and > >> > ColBg. > >> > --- > >> > drw.h | 2 +- > >> > dwm.c | 1 - > >> > 2 files changed, 1 insertion(+), 2 deletions(-) > >> > diff --git a/drw.h b/drw.h > >> > index 4c67419..4bcd5ad 100644 > >> > --- a/drw.h > >> > +++ b/drw.h > >> > @@ -12,7 +12,7 @@ typedef struct Fnt { > >> > struct Fnt *next; > >> > } Fnt; > >> > > >> > -enum { ColFg, ColBg }; /* Clr scheme index */ > >> > +enum { ColFg, ColBg, ColBorder }; /* Clr scheme index */ > >> > typedef XftColor Clr; > >> > > >> > typedef struct { > >> > diff --git a/dwm.c b/dwm.c > >> > index ec6a27c..ab16c75 100644 > >> > --- a/dwm.c > >> > +++ b/dwm.c > >> > @@ -56,7 +56,6 @@ > >> > #define HEIGHT(X) ((X)->h + 2 * (X)->bw) > >> > #define TAGMASK ((1 << LENGTH(tags)) - 1) > >> > #define TEXTW(X) (drw_fontset_getwidth(drw, (X)) + > >> > lrpad) > >> > -#define ColBorder 2 > >> > > >> > /* enums */ > >> > enum { CurNormal, CurResize, CurMove, CurLast }; /* cursor */ > >> > -- > >> > 2.7.4 > >> > >> Hey, > >> > >> Thanks for your patch. > >> > >> The patch didn't apply for me and your e-mail is changed in the commit. > >> > >> I've fixed this and pushed the commit to master. > >> > >> -- > >> Kind regards, > >> Hiltjo > >> > > > >
