[HACKYSTAT-DEV-L:34] [REPOST] Review Request 9/7/04

[Philip Johnson]

[Takuya's review announcement had some typos and missing information. Since people tend to use 
the last review announcement as their template for the next, I am reposting a new version to 
use as a template for future announcements, and taking the opportunity to do a little 
re-organization.  I've also updated Review.html with this version.]

Greetings, folks:
This Wednesday (09.07.2004) at noon in POST 307, we will be reviewing the Daily Project
classes in the hackyReview module. To perform this review:
0. Install and/or update (a) the Eclipse Jupiter plug-in and (b) The Hackystat Jupiter 
sensor.
1. Update the hackyReview module from CVS.
2. Select "ProjectActiveTime2" as the ReviewID.
Please review the following files:
* MostReviewActiveData.java
* DailyProjectReviewActiveTime.java
* ReviewActivityReducer.java
I am particularly concerned about the following:
1. How should the code determine the most active review file? Currently, the file with the 
most review ID and the most review phase is returned in this method. This will enable us to 
analyze the most review active file filtered by review ID or review phase, or both.

2. In DailyProjectActiveTime, is the any way to avoid the hard-coded 5, which converts the 
DayArray index into the number of minutes that it represents?  Should the DayArray have a 
static constant field such as DayArray.INTERVAL?

3. In DailyProjectReviewActiveTime:166, should I check the unchecked exception here? 
DayArrayException will be thrown if clients (I ) use the following incorrectly :

reviewActiveData.getDayArray().iterator()
i.nextNonempty()
However, the regular use of the iterator pattern in Java does not force clients to check the 
unchecked exception, but if the clients use it incorrectly, the IndexOutOfBoundsException 
(unchecked) will be thrown. Since we know the contract of the violation that we are supposed 
to use i.hasNextNonempty() and i.nextNonempty() step by step, should I retain the catch clause 
in my code?

-------------------------------------------------------------
Supplemental Links and Resources:
The Hackystat Code Review Guidelines:
* http://hackydev.ics.hawaii.edu/hackyDevSite/doc/Review.html
The Elements of Hacky Style:
* http://hackydev.ics.hawaii.edu/hackyDevSite/doc/EHS.html
Jupiter Code Review Tool documentation:
* http://csdl.ics.hawaii.edu/Tools/Jupiter/Core/doc/UsersGuide.html
Hackystat Jupiter Sensor documentation:
* 
<http://hackystat.ics.hawaii.edu/hackystat/controller?Page=help&Subpage=install&Sensor=Eclipse-Jupiter>

Thanks for reviewing the code!
Takuya
================================
Takuya Yamashita
E-mail: [EMAIL PROTECTED]
================================