Hello Everyone,

>From the code review I found one item that people might want to
affirm/confirm/comment on.
>>>>>>>>>>>>>>>>>>
Review comment: "The javadoc for the createTestProjectClientSide
method you're using does not explicity say this, but i think that you
do not _have_ to delete client side test projects."

Relevant code:
  protected void tearDown() throws Exception {
    ProjectManager.getInstance().deleteProject(
    this.testProjectGhostName);
  }

My comment: I copied this implementation structure from another
reducer test case that I did not author.
<<<<<<<<<<<<<<<<<

>>>>>>>>>>>>>>>>>
Review comment: "There is no constructor for this reduction function.
That 'smells bad' to me.  Non-trivial OO classes normally require a
constructor (or two)."
Relevant code: the IssueReducer
My comment: as far as I know, none of the reducers have a constructor.
<<<<<<<<<<<<<<<<<


Please let me know, thanks.
Burt

Reply via email to