--On Monday, April 18, 2005 2:01 AM -1000 Burt Leung <[EMAIL PROTECTED]> wrote:
Review comment: "There is no constructor for this reduction function. That 'smells bad' to me. Non-trivial OO classes normally require a constructor (or two)." Relevant code: the IssueReducer My comment: as far as I know, none of the reducers have a constructor. <<<<<<<<<<<<<<<<<
I was the one who wrote this comment, and you can mark it as 'invalid-won't fix'. I didn't realize at the time that reduction function classes have to obey servlet-style semantics (singleton, thread-safe). Since you're typically not going to have any instance variables in a reduction function, use of the implicit constructor seems reasonable.
Cheers, Philip
