[
https://issues.apache.org/jira/browse/HADOOP-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475674
]
David Bowen commented on HADOOP-941:
------------------------------------
> In this tradeoff between larger [generated] code size and smaller source
> code, I choose smaller source code.
It seems to me that the amount of code added to the compiler for this feature
is very small. There are a bit over 2000 lines of code in
org.apache.hadoop.record.compiler. The support for "-hadoop" consists of one
line to extract the command-line option, and three if-thens to omit parts which
are not needed outside of Hadoop. So that makes seven lines, counting the
lines containing the closing braces.
I don't know how bad it is to have the larger generated code. On test cases it
looks like the size is roughly doubled. That is perhaps much less of an issue
than having to either bundle the hadoop jar file or else carefully disentangle
the needed parts. I realized after I wrote my previous comment that it is not
just a matter of bundling the Writable and WritableComparable interfaces. The
generated code subclasses WritableComparator, so that it and the transitive
closure of its dependencies would need to be bundled also.
So, once again: this feature provides a clear benefit at a negligible cost in
complexity, and it should be accepted on its merits.
> Make Hadoop Record I/O Easier to use outside Hadoop
> ---------------------------------------------------
>
> Key: HADOOP-941
> URL: https://issues.apache.org/jira/browse/HADOOP-941
> Project: Hadoop
> Issue Type: Improvement
> Components: record
> Affects Versions: 0.10.1
> Environment: All
> Reporter: Milind Bhandarkar
> Assigned To: Milind Bhandarkar
> Attachments: jute-patch.txt
>
>
> Hadoop record I/O can be used effectively outside of Hadoop. It would
> increase its utility if developers can use it without having to import hadoop
> classes, or having to depend on Hadoop jars. Following changes to the current
> translator and runtime are proposed.
> Proposed Changes:
> 1. Use java.lang.String as a native type for ustring (instead of Text.)
> 2. Provide a Buffer class as a native Java type for buffer (instead of
> BytesWritable), so that later BytesWritable could be implemented as following
> DDL:
> module org.apache.hadoop.io {
> record BytesWritable {
> buffer value;
> }
> }
> 3. Member names in generated classes should not have prefixes 'm' before
> their names. In the above example, the private member name would be 'value'
> not 'mvalue' as it is done now.
> 4. Convert getters and setters to have CamelCase. e.g. in the above example
> the getter will be:
> public Buffer getValue();
> 5. Provide a 'swiggable' C binding, so that processing the generated C code
> with swig allows it to be used in scripting languages such as Python and Perl.
> 6. The default --language="java" target would generate class code for records
> that would not have Hadoop dependency on WritableComparable interface, but
> instead would have "implements Record, Comparable". (i.e. It will not have
> write() and readFields() methods.) An additional option "--writable" will
> need to be specified on rcc commandline to generate classes that "implements
> Record, WritableComparable".
> 7. Optimize generated write() and readFields() methods, so that they do not
> have to create BinaryOutputArchive or BinaryInputArchive every time these
> methods are called on a record.
> 8. Implement ByteInStream and ByteOutStream for C++ runtime, as they will be
> needed for using Hadoop Record I/O with forthcoming C++ MapReduce framework
> (currently, only FileStreams are provided.)
> 9. Generate clone() methods for records in Java i.e. the generated classes
> should implement Cloneable.
> 10. As part of Hadoop build process, produce a tar bundle for Record I/O
> alone. This tar bundle will contain the translator classes and ant task
> (lib/rcc.jar), translator script (bin/rcc), Java runtime (recordio.jar) that
> includes org.apache.hadoop.record.*, sources for the java runtime (src/java),
> and c/c++ runtime sources with Makefiles (src/c++, src/c).
> 11. Make generated Java codes for maps and vectors use Java generics.
> These are the proposed user-visible changes. Internally, the translator will
> be restructured so that it is easier to plug-in translators for different
> targets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
