[
https://issues.apache.org/jira/browse/HADOOP-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475970
]
Doug Cutting commented on HADOOP-1041:
--------------------------------------
> the ResourceBundle file name would be something like
> HaddopCounterNames.properties
Shouldn't we have a separate bundle for each enumeration, so that applications
can easily drop in new bundles for their properties? Thus the resource name
should perhaps be org/apache/hadoop/examples/RandomWriter$Counters.properties
in this case. Also, we might have more than one property per counter, e.g.:
BYTES_WRITTEN.name="bytes written"
BYTES_WRITTEN.description="Number of bytes written by RandomWriter example
program."
The descriptions could be used, e.g., in rollover help text.
> Counter names are ugly
> ----------------------
>
> Key: HADOOP-1041
> URL: https://issues.apache.org/jira/browse/HADOOP-1041
> Project: Hadoop
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.12.0
> Reporter: Owen O'Malley
> Fix For: 0.12.0
>
>
> Having the complete class name in the counter names makes them unique, but
> they are ugly to present to non-developers. It would be nice to have some way
> to have a nicer string presented to the user. Currently, the Enum is
> converted to a name like:
> key.getDeclaringClass().getName() + "#" + key.toString()
> which gives counter names like
> "org.apache.hadoop.examples.RandomWriter$Counters#BYTES_WRITTEN"
> which is unique, but not very user friendly. Perhaps, we should strip off the
> class name for presenting to the users, which would allow them to make nice
> names. In particular, you could define an enum type that overloaded toString
> to print a nice user friendly string.
> Thoughts?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
