[ 
https://issues.apache.org/jira/browse/HADOOP-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490470
 ] 

Doug Cutting commented on HADOOP-1272:
--------------------------------------

> org.apache.hadoop.dfs.servlets

Generally packages should be based on what the code does, not how it does it.  
So I wouldn't think that the servlets should be in a sub-package.  Rather, the 
namenode, datanode and client might be in separate packages.

> In general we should not multiply inner classes but rather create separate 
> ones.

Inner classes are fine so long as they don't get too big.

> Extract InnerClasses from FSNamesystem into separate classes
> ------------------------------------------------------------
>
>                 Key: HADOOP-1272
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1272
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: dhruba borthakur
>         Assigned To: dhruba borthakur
>         Attachments: innerclasses.patch
>
>
> This will make the code cleaner. Also, it leads itself to a cleaner and 
> easily understandable finer-grain locking model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to