[
https://issues.apache.org/jira/browse/HADOOP-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493815
]
Konstantin Shvachko commented on HADOOP-1298:
---------------------------------------------
- ClientProtocol.getFileInfo() is redundant, getListing() can be used instead.
Also open() will return DFSFileInfo, see HADOOP-894.
- Instead of separate ClientProtocol.chmod, .chgrp and .chown should we have
just one
changeStatus(FileStatus). I am talking about the protocol +and+ the name-node,
where there is a lot of repetitions.
This should not affect the client or fs api.
- Same with FSEditsLog. Why treat those three separately? I'd propose to replace
OP_CHMOD, OP_CHGRP, OP_CHOWN => OP_CHSTAT
This should be pretty general. If in the future we will introduce other file
attributes we do not
want to create a separate set of methods on all levels for each of them.
- Same with unprotectedChmod() and protectedChmod(), etc.
It inflates the code. It's easy to create it that way, but then hard to
maintain.
- If you change LAYOUT_VERSION you should add a comment what is changed
compared to the latest version.
- Please do not multiply methods with deprecated types line getFileInfo(UTF8
src). Strings should be used instead.
> adding user info to file
> ------------------------
>
> Key: HADOOP-1298
> URL: https://issues.apache.org/jira/browse/HADOOP-1298
> Project: Hadoop
> Issue Type: New Feature
> Components: dfs, fs
> Reporter: Kurtis Heimerl
> Attachments: hadoop-user-munncha.patch, hadoop-user-munncha.patch,
> hadoop-user-munncha.patch, hadoop-user-munncha.patch4,
> hadoop-user-munncha.patch5, hadoop-user-munncha.patch6,
> hadoop-user-munncha.patch7, hadoop-user-munncha.patch8
>
>
> I'm working on adding a permissions model to hadoop's DFS. The first step is
> this change, which associates user info with files. Following this I'll
> assoicate permissions info, then block methods based on that user info, then
> authorization of the user info.
> So, right now i've implemented adding user info to files. I'm looking for
> feedback before I clean this up and make it offical.
> I wasn't sure what release, i'm working off trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
