[
https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515469
]
Tsz Wo (Nicholas), SZE commented on HADOOP-1653:
------------------------------------------------
Codes look good. I like the ideas of making FSDirectory.INode static and using
StringBuffer. It helps reducing memory usages.
Since you are editing FSEditLog, could you also remove the use of the
deprecated UTF8 in logCreateFile and logMkDir?
Thanks.
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070725-1706.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per
> INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName()
> and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
