[
https://issues.apache.org/jira/browse/HADOOP-2268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12546860
]
Doug Cutting commented on HADOOP-2268:
--------------------------------------
Sigh. I hate back-compatibility-mandated changes, but back-compatibility is
really important for users. This is a reminder of why we should minimize our
public APIs and attempt to future-proof them whenever possible.
> I'm not sure what good names would be for the getReadyJobs, getSuccessfulJobs
> and getFailedJobs methods.
Perhaps we can drop the 'get'? readyJobs(), successfulJobs() and failedJobs()
are fine method names that convey pretty much the same thing. The use of 'get'
in no-arg method names is usually redundant anyway.
> JobControl classes should use interfaces rather than implemenations
> -------------------------------------------------------------------
>
> Key: HADOOP-2268
> URL: https://issues.apache.org/jira/browse/HADOOP-2268
> Project: Hadoop
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.15.0
> Reporter: Adrian Woodhead
> Assignee: Adrian Woodhead
> Priority: Minor
> Fix For: 0.16.0
>
> Attachments: HADOOP-2268-1.patch, HADOOP-2268-2.patch
>
>
> See HADOOP-2202 for background on this issue. Arun C. Murthy agrees that when
> possible it is preferable to program against the interface rather than a
> concrete implementation (more flexible, allows for changes of the
> implementation in future etc.) JobControl currently exposes running, waiting,
> ready, successful and dependent jobs as ArrayList rather than List. I propose
> to change this to List.
> I will code up a patch for this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
