[
https://issues.apache.org/jira/browse/HADOOP-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549560
]
stack commented on HADOOP-1550:
-------------------------------
Only critical things are that teardown should pass the miniHdfs instance to
StaticTestEnvironment.shutdownDfs (I know, the other tests need to do this too
-- we need to fix this) and you ahve redundant imports (I'll give you $5
dollars if you come by and let me help you do your eclipse setup).
Otherwise, non-blocking minor items:
+ You might add test that adds a pure column family, one w/o qualifier -- just
to be sure that works. You might assert that cell values actually made it into
hbase before you check to see if they have been deleted.
+ line lengths are generally <= 80 FYI.
+ Do you need to call the 'fail' -- just asking? Any harm letting the null
fall into the subsequent assertEquals?
+ Could you do 'Test.getLength() <= 0' instead of
getColumn().toString().equals("") and save on a convertion to String? Same
here 'origin.getColumn().equals(new Text())'.
This is interesting:
- if(HLogEdit.isDeleted(readval.get())) {
+ if(isDeleted(readkey, readval.get(), true, deletes)) {
DId you find a bug in our getFull?
Change this javadoc -- 'Test that the @param target ...' -- to <i>target</i>
(drop the @param -- might confuse javadoc tool or at minimum, looks odd in
produced javadoc). Same for @param origin.
Just FYI, this:
{code}
+ if (target.getRow().equals(origin.getRow())) {
+ // check the timestamp
+ return target.getTimestamp() <= origin.getTimestamp();
+ } else {
+ return false;
+ }
{code}
could be written as:
{code}
return (target.getRow().equals(origin.getRow())) ? target.getTimestamp() <=
origin.getTimestamp();: false;
{code}
Just FYI.
Otherwise, good on you. You've (nearly) nailed a tough nugget.
> [hbase] No means of deleting a'row' nor all members of a column family
> ----------------------------------------------------------------------
>
> Key: HADOOP-1550
> URL: https://issues.apache.org/jira/browse/HADOOP-1550
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: stack
> Assignee: Bryan Duxbury
> Attachments: 1550-v2.patch, 1550-v3.patch, 1550-v4.patch, 1550.patch
>
>
> There is no support in hbase currently for deleting a row -- i.e. remove all
> columns and their versions keyed by a particular row id. Nor is there a
> means of passing in a row id and column family name having hbase delete all
> members of the column family (for the designated row).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
