[
https://issues.apache.org/jira/browse/HAMA-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130369#comment-13130369
]
Edward J. Yoon commented on HAMA-457:
-------------------------------------
However, overall looks good to me.
And, patch is not work for me.
{code}
edward@slave:~/workspace/hama-trunk$ patch -p0 < HAMA-457_v2.patch
patching file core/conf/hama-default.xml
patching file core/src/test/java/org/apache/hama/HamaTestCase.java
patching file core/src/test/java/org/apache/hama/bsp/BSPSerializerWrapper.java
patching file
core/src/test/java/org/apache/hama/bsp/TestBSPMasterGroomServer.java
patching file core/src/test/java/org/apache/hama/checkpoint/TestCheckpoint.java
patching file core/src/main/java/org/apache/hama/zookeeper/QuorumPeer.java
patching file core/src/main/java/org/apache/hama/bsp/GroomServer.java
patching file core/src/main/java/org/apache/hama/bsp/BSPPeerImpl.java
patching file core/src/main/java/org/apache/hama/bsp/sync/SyncServer.java
patching file
core/src/main/java/org/apache/hama/bsp/sync/zookeeper/ZooKeeperSyncClientImpl.java
patching file
core/src/main/java/org/apache/hama/bsp/sync/zookeeper/ZooKeeperSyncServerImpl.java
patching file
core/src/main/java/org/apache/hama/bsp/sync/rpc/RPCSyncClientImpl.java
patching file core/src/main/java/org/apache/hama/bsp/sync/rpc/RPCSyncServer.java
patching file
core/src/main/java/org/apache/hama/bsp/sync/rpc/RPCSyncServerImpl.java
patching file
core/src/main/java/org/apache/hama/bsp/sync/SyncServiceFactory.java
patching file core/src/main/java/org/apache/hama/bsp/sync/SyncClient.java
patching file core/src/main/java/org/apache/hama/bsp/BSPPeer.java
patching file core/src/main/java/org/apache/hama/bsp/BSPSerializableMessage.java
patching file core/src/main/java/org/apache/hama/bsp/BSPMessageSerializer.java
patching file core/src/main/java/org/apache/hama/bsp/LocalBSPRunner.java
patching file
core/src/main/java/org/apache/hama/checkpoint/CheckpointRunner.java
patching file core/src/main/java/org/apache/hama/checkpoint/Checkpointer.java
patching file core/src/main/java/org/apache/hama/util/StringArrayWritable.java
Hunk #1 FAILED at 15.
1 out of 1 hunk FAILED -- saving rejects to file
core/src/main/java/org/apache/hama/util/StringArrayWritable.java.rej
patching file core/src/main/java/org/apache/hama/util/BSPNetUtils.java
patching file yarn/src/main/java/org/apache/hama/bsp/BSPApplicationMaster.java
patching file
yarn/src/main/java/org/apache/hama/bsp/sync/StringArrayWritable.java
patching file yarn/src/main/java/org/apache/hama/bsp/sync/SyncServer.java
patching file yarn/src/main/java/org/apache/hama/bsp/sync/SyncServerImpl.java
patching file yarn/src/main/java/org/apache/hama/bsp/YARNBSPPeerImpl.java
{code}
> Refactoring of BSPPeerImpl
> --------------------------
>
> Key: HAMA-457
> URL: https://issues.apache.org/jira/browse/HAMA-457
> Project: Hama
> Issue Type: Improvement
> Affects Versions: 0.3.0
> Reporter: Thomas Jungblut
> Assignee: Thomas Jungblut
> Fix For: 0.4.0
>
> Attachments: HAMA-457.patch, HAMA-457_v2.patch
>
>
> Extract a sync service which allows the user to implement and configure their
> own services.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
