Hi Ben! On Thu, Oct 05, 2017 at 02:31:33PM +0000, Ben Shillito wrote: > Hi Dragan, > > The changes seem reasonable to me. A couple of things I should mention though. > > The branch name for 3.2.12.12 should be in the same format as 3.2.10 (i.e. > "v3.2.12"). The other thing is that the statement about 3.2.10 is not > correct. The Trie data files were large and the solution had become > unwieldly, so this has been removed from our repository. The Hash Trie > however, is completely interface compatible and is available from 3.2.12 > onwards. I suggest just stating "v3.2.12" and point out the new Hash Trie can > be obtained by signing up for free at > https://51degrees.com/products/store/on-premise-device-detection.
Thanks for the heads up. Too bad I merged the patch this morning by lack of any comment. Would you care to provide an updated patch on top of the current master to reflect the best suggestions ? Thanks, Willy
