Hi Willy, Yes of course. I have attached a patch which has the correct branch and updated instructions about where to get the free Hash Trie file now that it is no longer part of the git repository.
Regards, Ben Shillito Developer O: +44 1183 287152 E: [email protected] T: @51Degrees -----Original Message----- From: Willy TARREAU [mailto:[email protected]] Sent: 05 October 2017 15:50 To: Ben Shillito <[email protected]> Cc: Dragan Dosen <[email protected]>; [email protected] Subject: Re: [PATCHES] 51d: fix warning when building with 51Degrees release version 3.2.12.12 Hi Ben! On Thu, Oct 05, 2017 at 02:31:33PM +0000, Ben Shillito wrote: > Hi Dragan, > > The changes seem reasonable to me. A couple of things I should mention though. > > The branch name for 3.2.12.12 should be in the same format as 3.2.10 (i.e. > "v3.2.12"). The other thing is that the statement about 3.2.10 is not > correct. The Trie data files were large and the solution had become > unwieldly, so this has been removed from our repository. The Hash Trie > however, is completely interface compatible and is available from 3.2.12 > onwards. I suggest just stating "v3.2.12" and point out the new Hash Trie can > be obtained by signing up for free at > https://51degrees.com/products/store/on-premise-device-detection. Thanks for the heads up. Too bad I merged the patch this morning by lack of any comment. Would you care to provide an updated patch on top of the current master to reflect the best suggestions ? Thanks, Willy This email and any attachments are confidential and may also be privileged. If you are not the named recipient, please notify the sender immediately and do not disclose, use, store or copy the information contained herein. This is an email from 51Degrees.mobi Limited, 5 Charlotte Close, Reading. RG47BY. T: +44 118 328 7152; E: [email protected]; 51Degrees.mobi Limited t/as 51Degrees.
0001-DOC-51d-Update-51Degrees-git-URL-to-feature-frozen-b.patch
Description: 0001-DOC-51d-Update-51Degrees-git-URL-to-feature-frozen-b.patch
