On Wed, Dec 15, 2010 at 09:01:32AM +0100, Cyril Bonté wrote: > Le mercredi 15 décembre 2010 07:29:23, Willy Tarreau a écrit : > > All 3 patches applied, thanks Cyril ! > > Also, that was a good idea to think about the admin_rules. It took me > > some time to find the relation until I reminded the enable/disable buttons > > ! > > Yes ! And I'll maybe have to send an update because I realize the stats > checks > are incomplete : currently, I verify that the stats proxy is assigned to only > one process. This is not enough if the other proxies are assigned to > different > processes. > > Example : > global > daemon > nbproc 8 > > listen stats :8000 > bind-process 1 > mode http > stats enable > stats admin if LOCALHOST > > listen http-in :80 > mode http > server http 192.168.0.1:80 > > The idea is to check each proxy in the scope of the stats and compare their > bind-process mask with the current stats proxy.
I would do something simpler : only report a warning if one proxy is running with stats admin and with a bind-process mask which has 2 bits set (is not a power of 2). This is the correct condition to decide of an anomaly because an action will be sent to a random process. If the administrator correctly binds his proxies to a specific process, he likely knows what he's doing and we should not report an annoying warning here. Willy
