Hi Lukas!

2013/4/11 Lukas Tribus <[email protected]>:
> Hi Hiroaki!
>
>> I made a patch to fix this problem.
>> After applying this patch, it seems work correctly now.
>
> Thank you, it does work with your patch applied, great!

Thank you for your testing!

>
>
> Now you are declaring error and erroffset outside "#ifdef USE_PCRE_JIT",
> but actually use them only inside. This causes a compiler warning
> (unused variable) when building without USE_PCRE_JIT.
>
> I'm not sure how to fix this correctly (in terms of coding style, etc).

Ah, how careless of me. Thanks for pointing me out!
I updated my patch and attached it with a filename 0002-PCRE_JIT_fix2.patch.

>All
When you try it, use this patch 0002-PCRE_JIT_fix2.patch instead of
0002-PCRE_JIT_fix.patch

Here is an updated build steps.

```
## pcre
cd /usr/local
curl -LO 
http://downloads.sourceforge.net/project/pcre/pcre/8.32/pcre-8.32.tar.bz2
tar xf pcre-8.32.tar.bz2
cd pcre-8.32
./configure --prefix=/usr/local --libdir=/usr/local/lib64 \
      --enable-jit --enable-utf
make
make install
echo /usr/local/lib64 > /etc/ld.so.conf.d/pcre-8.32.x86_64.conf
ldconfig

## haproxy
yum install -y openssl-devel zlib-devel
cd /usr/local
curl -LO http://haproxy.1wt.eu/download/1.5/src/devel/haproxy-1.5-dev18.tar.gz
tar xf haproxy-1.5-dev18.tar.gz
cd haproxy-1.5-dev18
patch -p1 < /usr/local/0001-MINOR-show-PCRE-version-and-JIT-status-in-vv.patch
patch -p1 < /usr/local/0002-PCRE_JIT_fix2.patch
make TARGET=linux2628 CPU=native USE_STATIC_PCRE=1 USE_PCRE_JIT=1
USE_OPENSSL=1 USE_ZLIB=1
make install
```

>
> Willy, could you review Hiroaki's patch and comment on the declaration
> issue?
>
>
> Thanks!
> Lukas

-- 
)Hiroaki Nakamura)

Attachment: 0002-PCRE_JIT_fix2.patch
Description: Binary data

Reply via email to