Hi Hiroaki, On Thu, Apr 11, 2013 at 09:48:05AM +0900, Hiroaki Nakamura wrote: > Hi Lukas! > > 2013/4/11 Lukas Tribus <[email protected]>: > > Hi Hiroaki! > > > >> I made a patch to fix this problem. > >> After applying this patch, it seems work correctly now. > > > > Thank you, it does work with your patch applied, great! > > Thank you for your testing! > > > > > > > Now you are declaring error and erroffset outside "#ifdef USE_PCRE_JIT", > > but actually use them only inside. This causes a compiler warning > > (unused variable) when building without USE_PCRE_JIT. > > > > I'm not sure how to fix this correctly (in terms of coding style, etc). > > Ah, how careless of me. Thanks for pointing me out! > I updated my patch and attached it with a filename 0002-PCRE_JIT_fix2.patch. > > >All > When you try it, use this patch 0002-PCRE_JIT_fix2.patch instead of > 0002-PCRE_JIT_fix.patch
Thank you, I'm going to apply it. Next time, could you please provide a short description of what the patch does (what it fixes and how) that I can add in the commit message ? This time I found it by looking at the patch and comparing with the man page, but sometimes it could be more subtile. > Here is an updated build steps. (...) If you think it could be useful, maybe this should go into in a dedicated file "pcre-jit.txt" in the doc/ directory, which would be quickly referenced from the README. We could even add there some of the results from your own experimentation. What do you think ? Best regards, Willy
