> > p.s.
> > Ive spotted a issue in my patch with the IPv6 part where i forgot about
> > the OpenBSD part (SOL_SOCKET & SO_BINDANY) should probably be added
> > there also.
>
> No problem, we'll add this as a third patch. It's really important to
> have one feature per commit, because when for some reason we introduce
> regressions, users can easily revert just the faulty commit without
> losing the other ones.
BTW, I noticed that we can safely remove the following tests :
- defined(SOL_IP)
- defined(SOL_IPV6)
=> both are used only on linux and were previously present
- defined(IPPROTO_IP)
- defined(IPPROTO_IPV6)
=> we already have many other IPPROTO_* defines (mainly IPPROTO_TCP)
so we already have the correct includes to use them.
- defined(SOL_SOCKET)
=> is already referenced a lot, so it's safe.
It's nice because it will clear the #ifdef a little bit.
Willy
