Hi Pieter,

On Thu, May 09, 2013 at 10:33:57PM +0200, PiBa-NL wrote:
> Hi Willy,
> 
> Thanks the patches look good, and when applied separately all compile 
> without issues on FreeBSD. (Except when using the USE_LINUX_TPROXY flag, 
> but that shouldn't be used on FreeBSD anyway.)
> And transparent proxying works correctly on FreeBSD as was expected.

Great, thanks for testing.

> Ive included a "transparent_proxy.cfg" which could be added to the 
> 'examples' folder of HAProxy. Though i'm not sure anyone would find it 
> there.

You can't imagine the amount of configs I see which begin with a line
saying "# this config needs haproxy-1.1.28 or haproxy-1.2.1"... It proves
that users have no problem finding such files in the examples directory !

> Also it includes quite a bit of 'supposedly' better configuration hints, 
> that i'm currently unable to verify, but still might help someone in the 
> future..

It's not a problem. Examples are contributed by the community. They're
better than nothing, and when someone disagrees or has something better
to propose, we just have to update. So don't worry, your config will
magically get fixed if it's not optimal.

> As for Linux i think some iptable rules are needed.  Maybe someone can 
> added those to the example.

Indeed, and I think that Baptiste wanted to blog something on the subject,
so probably at the same time he'll contribute the same hits to this file.

> If you don't want to include it in its current form or want to reformat 
> the whole thing i have no problem with that.

Fine, that's perfect!

Thanks!
Willy


Reply via email to