Hi David, On Tue, Apr 22, 2014 at 10:29:13PM -0400, David S wrote: > Here's an updated diff. I like it a lot better. > It addresses all of your comments, except adding support for > check-send-proxy-v2.
Indeed. I've checked how SRV_SEND_PROXY is used, and it could clearly be merged into ->pp_opts instead of ->state. Similarly, check-send-proxy sets check->send_proxy to anything but zero right now. Thus I think we should modify the check struct to have a similar pp_opts sharing the same values as srv->pp_opts. These values would be : - PP_SEND_V1 - PP_SEND_V2 The benefit is that anything you do for the servers will be much easier to reuse for the checks. Otherwise your patch looks fine. Do you want me to merge it ? If so, please could you provide a commit message with it ? Thanks, Willy
