On Wed, Apr 23, 2014 at 04:19:17PM -0400, David S wrote: > On Wed, Apr 23, 2014 at 5:45 AM, Willy Tarreau <[email protected]> wrote: > > > (...) > > Otherwise your patch looks fine. Do you want me to merge it ? If so, > > please could you provide a commit message with it ? > > > > Thanks, > > Willy > > > > First, I'll update the documentation to keep it in sync with the code. > > Thinking ahead to adding TLVs to follow the header, do you have a favorite > generic TLV implementation that you can merge in, or would you rather us > develop something specific from scratch?
Take a look at src/peers.c, from what I remember, the sync protocol uses TLV as well, but I don't remember if there was anything specific, as in my opinion it's quite straightforward. Concerning the length, we could use a variable size encoding but that's painful for the decoder in general. And sometimes even for the encoder. So probably better stick to 16 bits for all lengths. Thanks, Willy
