Hi Dave, On Tue, Jul 14, 2015 at 03:38:47PM +0000, Dave Zhu (yanbzhu) wrote: > >Emeric responded here: > >http://marc.info/?l=haproxy&m=143643724320705&w=2 > > > >Not sure what you mean by pushing this to master...? > > > > > > > >Lukas > > > > I¹ve corrected the indentation to use tabs instead of spaces. Here¹s the > new diff:
Thank you. BTW, your mailer is wrapping lines. It remains readable for this small patch but can become bothering in the future and will definitely prevent the patch from being applied (which was Emeric's problem since he couldn't apply it to review the code). If your mailer is problematic (which happens with some of them), just join the patch as a text attachment, it will work well and still be usable. > Is there a better method to do code reviews other than using the mailing > list? I¹ll use whatever is easiest for you guys. E-mails to the list with relevant people in CC is the best method, as anyone can spot anything there, propose some adjustments inline or alternatives. > Again, sorry for the delayed response. I¹ll track the website from now on, If you didn't receive Emeric's response, do you want me to send you a private e-mail from my work address so see if there's anything related to the domain itself ? Cheers, Willy
